Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ruby 3.0 and 3.1, rails 7.0 releases #149

Merged
merged 5 commits into from
Nov 30, 2022
Merged

Conversation

cjcolvar
Copy link
Member

@cjcolvar cjcolvar commented Nov 29, 2022

Rebase of #145 with additional commits to switch to Lamprey (rdf-ldp) as the LDP server used in integration tests and loosen the rdf and json-ld dependency requirements. Tests were also added for ruby 3.1 and rails 7.0.

Comment on lines +30 to +33
before do
# Initialize LDP server
subject.put "/", ""
end
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why this is needed with Lamprey, but without it the first test will fail unless that test is "creating resources".

@coveralls
Copy link

coveralls commented Nov 29, 2022

Coverage Status

Coverage increased (+1.5%) to 86.165% when pulling 5ff825e on allow-ruby-3.0-cjc into 69da705 on main.

@cjcolvar
Copy link
Member Author

The circleci jobs changed in this PR removing one that github is expecting.

@cjcolvar cjcolvar changed the title Support ruby 3.0 releases Support ruby 3.0 and 3.1 releases Nov 30, 2022
Copy link
Contributor

@jrgriffiniii jrgriffiniii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you very much for this @cjcolvar!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants