Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculating baseurl length instead of assumig based on default settings #11

Merged
merged 1 commit into from
Jul 31, 2015
Merged

Calculating baseurl length instead of assumig based on default settings #11

merged 1 commit into from
Jul 31, 2015

Conversation

escowles
Copy link
Contributor

@escowles
Copy link
Contributor Author

Hmm, the Travis build is failing because of this:

https://github.com/projecthydra/active_fedora/blob/master/lib/active_fedora.rb#L210

@jcoyne, do I need to set the environment in the Rakefile?

@jcoyne
Copy link
Member

jcoyne commented Jul 20, 2015

@escowles that error is saying that RAILS_ENV is set. But I don't see anywhere in the code that sets that, so I'm confused.

@escowles
Copy link
Contributor Author

It seems strange that Travis would set that without us configuring it. The other way to handle this would be to explicitly set the 'environment' variable. I tried to add that to the Rakefile but nothing worked for me.

…gs, adding tests for templates of varying lengths
@escowles
Copy link
Contributor Author

I resolved the Travis issue by explicitly specifying the rake invocation with the environment variable, and stubbing out the AF config to prevent attempts to connect to Fedora.

mjgiarlo added a commit that referenced this pull request Jul 31, 2015
Calculating baseurl length instead of assumig based on default settings
@mjgiarlo mjgiarlo merged commit e8e9278 into samvera:master Jul 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants