Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't calculate coverage on the generated test app #77

Merged
merged 1 commit into from
Dec 12, 2017
Merged

Don't calculate coverage on the generated test app #77

merged 1 commit into from
Dec 12, 2017

Conversation

jcoyne
Copy link
Member

@jcoyne jcoyne commented Dec 12, 2017

Previously simplecov was reporting coverage on files in .internal_test_app/

@coveralls
Copy link

coveralls commented Dec 12, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-4.9%) to 94.382% when pulling 1bd426d on coverage into 1f94e5e on master.

@mjgiarlo
Copy link
Member

@jcoyne Did you expect this to lower coverage?

@jcoyne
Copy link
Member Author

jcoyne commented Dec 12, 2017

@mjgiarlo yes, we removed things that were well covered but in .internal_test_app

@jcoyne jcoyne merged commit 2381e67 into master Dec 12, 2017
@jcoyne jcoyne deleted the coverage branch December 12, 2017 15:52
@mjgiarlo
Copy link
Member

@jcoyne 🆗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escowles escowles escowles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jcoyne @coveralls @mjgiarlo @escowles