Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

null safety fix #3

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 19 additions & 20 deletions lib/data/api/api_util.dart
Original file line number Diff line number Diff line change
@@ -1,20 +1,19 @@
import 'package:habr_flutter_clean_arch/data/api/request/get_day_body.dart';
import 'package:habr_flutter_clean_arch/data/mapper/day_mapper.dart';
import 'package:meta/meta.dart';
import 'package:habr_flutter_clean_arch/data/api/service/sunrise_service.dart';
import 'package:habr_flutter_clean_arch/domain/model/day.dart';

class ApiUtil {
final SunriseService _sunriseService;

ApiUtil(this._sunriseService);

Future<Day> getDay({
@required double latitude,
@required double longitude,
}) async {
final body = GetDayBody(latitude: latitude, longitude: longitude);
final result = await _sunriseService.getDay(body);
return DayMapper.fromApi(result);
}
}
import 'package:habr_flutter_clean_arch/data/api/request/get_day_body.dart';
import 'package:habr_flutter_clean_arch/data/mapper/day_mapper.dart';
import 'package:habr_flutter_clean_arch/data/api/service/sunrise_service.dart';
import 'package:habr_flutter_clean_arch/domain/model/day.dart';

class ApiUtil {
final SunriseService _sunriseService;

ApiUtil(this._sunriseService);

Future<Day> getDay({
required double latitude,
required double longitude,
}) async {
final body = GetDayBody(latitude: latitude, longitude: longitude);
final result = await _sunriseService.getDay(body);
return DayMapper.fromApi(result);
}
}
24 changes: 12 additions & 12 deletions lib/data/api/model/api_day.dart
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
class ApiDay {
final String sunrise;
final String sunset;
final String solarNoon;
final num dayLength;

ApiDay.fromApi(Map<String, dynamic> map)
: sunrise = map['results']['sunrise'],
sunset = map['results']['sunset'],
solarNoon = map['results']['solar_noon'],
dayLength = map['results']['day_length'];
}
class ApiDay {
final String sunrise;
final String sunset;
final String solarNoon;
final num dayLength;
ApiDay.fromApi(Map<String, dynamic> map)
: sunrise = map['results']['sunrise'],
sunset = map['results']['sunset'],
solarNoon = map['results']['solar_noon'],
dayLength = map['results']['day_length'];
}
36 changes: 17 additions & 19 deletions lib/data/api/request/get_day_body.dart
Original file line number Diff line number Diff line change
@@ -1,19 +1,17 @@
import 'package:meta/meta.dart';

class GetDayBody {
final double latitude;
final double longitude;

GetDayBody({
@required this.latitude,
@required this.longitude,
});

Map<String, dynamic> toApi() {
return {
'lat': latitude,
'lng': longitude,
'formatted': 0,
};
}
}
class GetDayBody {
final double latitude;
final double longitude;

GetDayBody({
required this.latitude,
required this.longitude,
});

Map<String, dynamic> toApi() {
return {
'lat': latitude,
'lng': longitude,
'formatted': 0,
};
}
}
38 changes: 19 additions & 19 deletions lib/data/api/service/sunrise_service.dart
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
import 'package:dio/dio.dart';
import 'package:habr_flutter_clean_arch/data/api/model/api_day.dart';
import 'package:habr_flutter_clean_arch/data/api/request/get_day_body.dart';

class SunriseService {
static const _BASE_URL = 'https://api.sunrise-sunset.org';

final Dio _dio = Dio(
BaseOptions(baseUrl: _BASE_URL),
);

Future<ApiDay> getDay(GetDayBody body) async {
final response = await _dio.get(
'/json',
queryParameters: body.toApi(),
);
return ApiDay.fromApi(response.data);
}
}
import 'package:dio/dio.dart';
import 'package:habr_flutter_clean_arch/data/api/model/api_day.dart';
import 'package:habr_flutter_clean_arch/data/api/request/get_day_body.dart';
class SunriseService {
static const _base_url = 'https://api.sunrise-sunset.org';
final Dio _dio = Dio(
BaseOptions(baseUrl: _base_url),
);
Future<ApiDay> getDay(GetDayBody body) async {
final response = await _dio.get(
'/json',
queryParameters: body.toApi(),
);
return ApiDay.fromApi(response.data);
}
}
26 changes: 13 additions & 13 deletions lib/data/mapper/day_mapper.dart
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
import 'package:habr_flutter_clean_arch/data/api/model/api_day.dart';
import 'package:habr_flutter_clean_arch/domain/model/day.dart';

class DayMapper {
static Day fromApi(ApiDay day) {
return Day(
sunrise: DateTime.tryParse(day.sunrise),
sunset: DateTime.tryParse(day.sunset),
solarNoon: DateTime.tryParse(day.solarNoon),
dayLength: day.dayLength.toInt(),
);
}
}
import 'package:habr_flutter_clean_arch/data/api/model/api_day.dart';
import 'package:habr_flutter_clean_arch/domain/model/day.dart';
class DayMapper {
static Day fromApi(ApiDay day) {
return Day(
sunrise: DateTime.tryParse(day.sunrise)!,
sunset: DateTime.tryParse(day.sunset)!,
solarNoon: DateTime.tryParse(day.solarNoon)!,
dayLength: day.dayLength.toInt(),
);
}
}
30 changes: 16 additions & 14 deletions lib/data/repository/day_data_repository.dart
Original file line number Diff line number Diff line change
@@ -1,14 +1,16 @@
import 'package:habr_flutter_clean_arch/data/api/api_util.dart';
import 'package:habr_flutter_clean_arch/domain/model/day.dart';
import 'package:habr_flutter_clean_arch/domain/repository/day_repository.dart';

class DayDataRepository extends DayRepository {
final ApiUtil _apiUtil;

DayDataRepository(this._apiUtil);

@override
Future<Day> getDay({double latitude, double longitude}) {
return _apiUtil.getDay(latitude: latitude, longitude: longitude);
}
}
import 'package:habr_flutter_clean_arch/data/api/api_util.dart';
import 'package:habr_flutter_clean_arch/domain/model/day.dart';
import 'package:habr_flutter_clean_arch/domain/repository/day_repository.dart';

class DayDataRepository extends DayRepository {
final ApiUtil _apiUtil;

DayDataRepository(this._apiUtil);

@override
Future<Day> getDay({ required double latitude, required double longitude}) {

return _apiUtil.getDay(latitude: latitude, longitude: longitude);

}
}
29 changes: 14 additions & 15 deletions lib/domain/model/day.dart
Original file line number Diff line number Diff line change
@@ -1,15 +1,14 @@
import 'package:meta/meta.dart';

class Day {
final DateTime sunrise;
final DateTime sunset;
final DateTime solarNoon;
final int dayLength;

Day({
@required this.sunrise,
@required this.sunset,
@required this.solarNoon,
@required this.dayLength,
});
}

class Day {
final DateTime sunrise;
final DateTime sunset;
final DateTime solarNoon;
final int dayLength;

Day({
required this.sunrise,
required this.sunset,
required this.solarNoon,
required this.dayLength,
});
}
17 changes: 8 additions & 9 deletions lib/domain/repository/day_repository.dart
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
import 'package:meta/meta.dart';
import 'package:habr_flutter_clean_arch/domain/model/day.dart';

abstract class DayRepository {
Future<Day> getDay({
@required double latitude,
@required double longitude,
});
}
import 'package:habr_flutter_clean_arch/domain/model/day.dart';

abstract class DayRepository {
Future<Day> getDay({
required double latitude,
required double longitude,
});
}
65 changes: 34 additions & 31 deletions lib/domain/state/home/home_state.dart
Original file line number Diff line number Diff line change
@@ -1,31 +1,34 @@
import 'package:mobx/mobx.dart';
import 'package:meta/meta.dart';
import 'package:habr_flutter_clean_arch/domain/repository/day_repository.dart';
import 'package:habr_flutter_clean_arch/domain/model/day.dart';

part 'home_state.g.dart';

class HomeState = HomeStateBase with _$HomeState;

abstract class HomeStateBase with Store {
HomeStateBase(this._dayRepository);

final DayRepository _dayRepository;

@observable
Day day;

@observable
bool isLoading = false;

@action
Future<void> getDay({
@required double latitude,
@required double longitude,
}) async {
isLoading = true;
final data = await _dayRepository.getDay(latitude: latitude, longitude: longitude);
day = data;
isLoading = false;
}
}
import 'package:mobx/mobx.dart';
import 'package:habr_flutter_clean_arch/domain/repository/day_repository.dart';
import 'package:habr_flutter_clean_arch/domain/model/day.dart';

part 'home_state.g.dart';

class HomeState = HomeStateBase with _$HomeState;

abstract class HomeStateBase with Store {
final DayRepository _dayRepository;

HomeStateBase(this._dayRepository);

@observable
late Day day;

@observable
bool isLoading = false;
@observable
bool isGeted = false;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Для чего потребовалось вводить новое поле?



@action
Future<void> getDay({
required double latitude,
required double longitude,
}) async {
isLoading = true;
final data = await _dayRepository.getDay(latitude: latitude, longitude: longitude);
day = data;
isGeted = true;
isLoading = false;
}
}
35 changes: 28 additions & 7 deletions lib/domain/state/home/home_state.g.dart

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading