Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Ceibo descriptor get for new collection #406

Merged
merged 1 commit into from
Dec 6, 2018
Merged

Conversation

ro0gr
Copy link
Collaborator

@ro0gr ro0gr commented May 18, 2018

This is the last Ceibo's value usage mentioned in #405

@san650
Copy link
Owner

san650 commented May 27, 2018

Can we rebase the PR on top of master? I think you already fixed the failing tests on master, right?

@ro0gr ro0gr force-pushed the get-for-new-collection branch from b0d9ca1 to f0352d6 Compare May 28, 2018 21:34
@coveralls
Copy link

coveralls commented May 28, 2018

Coverage Status

Coverage decreased (-0.2%) to 98.555% when pulling 727d9aa on get-for-new-collection into 7fa5913 on master.

@ro0gr ro0gr force-pushed the get-for-new-collection branch from f0352d6 to 727d9aa Compare November 19, 2018 22:09
@ro0gr ro0gr merged commit b399a9f into master Dec 6, 2018
@ro0gr
Copy link
Collaborator Author

ro0gr commented Dec 12, 2018

Hm.. seems like it changes collections behaviour in an un-desirable way:

const p = create({
  c: collection('.selector')
});

p.c === p.c // => false

prior to this change the nodes were equal.. Going to cover it by test and revert the commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants