Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Prevent is-rfc268-test to be treated as a test #416

Merged
merged 1 commit into from
Jun 29, 2018

Conversation

ro0gr
Copy link
Collaborator

@ro0gr ro0gr commented Jun 21, 2018

From Slack:

is-rfc268-test.js:4 Uncaught TypeError: Object.defineProperty called on non-object

so this happens with 1.15 betas only when trying to import useNativeEvents from the ember-cli-page-object/extend.

I don't fully understand the root cause of the issue, but here are my observations:

  • extend/index.js depends on -private/execution_context
  • which depends on -private/is-rfc268-test which causes an issue acording to error message
  • Somehow when -private/is-rfc268-test is referenced via this depency chain out of the test execution context(for example in the tests/test-helper.js) we get an error above. if I rename the -private/is-rfc268-test to avoid the "-test.js" suffix an error dissapears.

It could possible fix the other imports issues I have heard about earlier..

I think there are pretty low chances to test it on CI cause we need an external app/addon to include ember-cli-page-object for that.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.763% when pulling 3b872fb on is-rfc268--test into aaec068 on master.

@ro0gr ro0gr merged commit fcdf6be into master Jun 29, 2018
@san650 san650 deleted the is-rfc268--test branch June 29, 2018 20:44
@mydea
Copy link

mydea commented Nov 7, 2018

Any chance of getting a new release? Would be great :)

@ro0gr
Copy link
Collaborator Author

ro0gr commented Nov 11, 2018

@mydea thanks for heads up! Going to make new beta release early this week.

@ro0gr
Copy link
Collaborator Author

ro0gr commented Nov 13, 2018

Just published 1.15.0-beta.4, hoping to have a stable release soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants