[bugfix] Prevent is-rfc268-test to be treated as a test #416
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Slack:
so this happens with 1.15 betas only when trying to import
useNativeEvents
from theember-cli-page-object/extend
.I don't fully understand the root cause of the issue, but here are my observations:
extend/index.js
depends on-private/execution_context
-private/is-rfc268-test
which causes an issue acording to error message-private/is-rfc268-test
is referenced via this depency chain out of the test execution context(for example in thetests/test-helper.js
) we get an error above. if I rename the-private/is-rfc268-test
to avoid the "-test.js" suffix an error dissapears.It could possible fix the other imports issues I have heard about earlier..
I think there are pretty low chances to test it on CI cause we need an external app/addon to include
ember-cli-page-object
for that.