Async await guide #435
Merged
Async await guide #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
mistahenry
suggested changes
Nov 28, 2018
guides/migrations/async-await.md
Outdated
| --- | ||
| {% raw %} | ||
|
|
||
| If you migrate to `"@ember/test-helpers"` you should take care to update all your "actions" usages to leaverage `async`/`await` syntax. |
There was a problem hiding this comment.
If you migrate to "@ember/test-helpers"[,] you should take care to update all your "actions" usages to leaverage leverage async/await syntax.
guides/migrations/async-await.md
Outdated
| **Bad** | ||
| ```js | ||
| export default { | ||
| scope, |
There was a problem hiding this comment.
I find including this unreferenced scope here potentially confusing.
There was a problem hiding this comment.
This is not only confusing, it's also wrong. Will fix
mistahenry
reviewed
Dec 2, 2018
guides/migrations/async-await.md
Outdated
| --- | ||
| {% raw %} | ||
|
|
||
| When migrate to use `"@ember/test-helpers"`, you should take care to update all your "actions" usages to leverage `async`/`await` syntax. |
ro0gr
force-pushed
the
async-await-guide
branch
from
fc3fd43 to
ca6b0a8
Compare
|
Just updated per @mistahenry feedback. Also reverted moving of existing migration guides to a separate folder cause it could lead to a links breakage for the previous guide versions. |
|
Looks good to me now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sharing to track progress on the async/await migration guide.
In addition to the new page It also moves native-events mode page and upgrade instructions from v0 under "migrations/" directory for grouping purposes. Maybe we need a dedicated migrations section in the guides.abondoned it since moving of files would break navigation for the previous versions of guidesOne more point to note, we might want to include https://github.com/ro0gr/ember-page-object-codemod to the async/await migration guide. I don't think it's 100% proof solution, however it can be a useful starting point for migration. Tested it here chrislopresto/ember-freestyle#184