Feat/native getters #482
Merged
Feat/native getters #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR allows users to use native `get` syntax directly on page objects, as opposed to the `getter` macro. This syntax is much less verbose and easier to read overall. The implementation first ensures that all property descriptors are correctly copied to the final definition, then updates objects in the Ceibo builder to use the equivalent of the getter macro. This could also be added directly to Ceibo, but would likely still require some changes to ember-cli-page-object to ensure that descriptors are copied via `getOwnPropertyDescriptor` and `defineProperty` and not via simple assignment (which will activate the getter when attempting to assign it).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
restores #411
Huge thanks to @pzuraq for all the hard work done to implement this feature.