fix: restore getter error details #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(san650#596) broke QUnit error messages so they now miss contextual error info like page object path and selector. This happened cause san650#596 relied on the `.toString()` method of the Error to build the final error message. However, that's not how QUnit is displaying the error message. It just uses the `Error.message`. So let's build the final message in the `Error` constructor.
ro0gr
force-pushed
the
bugfix/missing-page-object-key-in-error
branch
from
4f72e1f to
24bdee2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#596 broke QUnit error messages so they now miss contextual error info like page object path and selector. This info only remained as a part of the console output.
Before:
This happened cause #596 relied on the
.toString()method of the Error to build the final error message. However, that's not how the error message is supposed to be displayed in UI.Instead, we need the
Error.messageto be complete. Let's build it in theErrorconstructor then.After:
