Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci) upgrade pnpm/action-setup to the current latest #643

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

ro0gr
Copy link
Collaborator

@ro0gr ro0gr commented Sep 29, 2024

it currently fails with the

Running self-installer...
   WARN  GET https://registry.npmjs.org/pnpm error (ERR_INVALID_THIS). Will retry in 10 seconds. 2 retries left.
   WARN  GET https://registry.npmjs.org/pnpm error (ERR_INVALID_THIS). Will retry in 1 minute. 1 retries left.
   ERR_PNPM_META_FETCH_FAIL  GET https://registry.npmjs.org/pnpm: Value of "this" must be of type URLSearchParams
Error: Something went wrong, self-installer exits with code 1

https://github.com/san650/ember-cli-page-object/actions/runs/11084629777/job/30825358176?pr=642#step:4:13

@ro0gr
Copy link
Collaborator Author

ro0gr commented Sep 29, 2024

The original issue seems to be fixed, but it now fails for the release, beta, and canary scenarios with

Object.hasOwn is not a function

https://github.com/san650/ember-cli-page-object/actions/runs/11096086617/job/30825526505?pr=643#step:6:62

I suspect it's not related to the ec-page-object, or at least I can't see an obvious "why", so let's go ahead and make the most of scenarios run and green.

@ro0gr ro0gr changed the title try upgrading pnpm/action-setup to the current latest fix(ci) upgrade pnpm/action-setup to the current latest Sep 29, 2024
@ro0gr ro0gr marked this pull request as ready for review September 29, 2024 21:58
@ro0gr ro0gr merged commit c023399 into san650:master Sep 29, 2024
11 of 14 checks passed
@ro0gr
Copy link
Collaborator Author

ro0gr commented Sep 29, 2024

oh.. seems we need to upgrade to the node@16 to support the Object.hasOwn(, let's do it as a follow up then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant