Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics Tracking and Log changes somehow? #3

Merged

Conversation

Galactus22625
Copy link
Collaborator

@Galactus22625 Galactus22625 commented Oct 16, 2024

Description

clean up logs? idk why those changes are in this branch
add metrics tracking
add metrics for issue requests count
added api latency metrics
added jira plug in read me

Issues Resolved

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has a documentation issue. Please link to it in this PR.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Galactus22625 and others added 6 commits October 14, 2024 14:15
Signed-off-by: Maxwell Brown <mxwelwbr@amazon.com>
Signed-off-by: Maxwell Brown <mxwelwbr@amazon.com>
Signed-off-by: Maxwell Brown <mxwelwbr@amazon.com>
Signed-off-by: Maxwell Brown <mxwelwbr@amazon.com>
Signed-off-by: Maxwell Brown <mxwelwbr@amazon.com>
@Galactus22625 Galactus22625 changed the title Saas with core refactor Metrics Tracking and Log changes somehow? Oct 16, 2024
Signed-off-by: Maxwell Brown <mxwelwbr@amazon.com>
Signed-off-by: Maxwell Brown <mxwelwbr@amazon.com>
Copy link
Owner

@san81 san81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for helping clean up the logs and adding metrics

@san81 san81 merged commit 75b335d into san81:saas-with-core-refactor Oct 16, 2024
38 of 49 checks passed
import java.util.concurrent.ConcurrentLinkedQueue;
import java.util.concurrent.ExecutorService;
import java.util.concurrent.Future;
import java.util.concurrent.*;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjust your intelij settings to not to use * import

Galactus22625 added a commit that referenced this pull request Oct 31, 2024
san81 added a commit that referenced this pull request Nov 2, 2024
# This is the 1st commit message:

additional test coverage

Signed-off-by: Santhosh Gandhe <1909520+san81@users.noreply.github.com>

# This is the commit message #2:

cleaned up JiraOauthConfig file

Signed-off-by: Santhosh Gandhe <1909520+san81@users.noreply.github.com>

# This is the commit message #3:

addressing review comments and simplifying the exception handling

Signed-off-by: Santhosh Gandhe <1909520+san81@users.noreply.github.com>

# This is the commit message #4:

Add external origination time for events created from S3 Object (opensearch-project#5104)

Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
Co-authored-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
# This is the commit message #5:

moved the wait block out of the catch block

Signed-off-by: Santhosh Gandhe <1909520+san81@users.noreply.github.com>

# This is the commit message #6:

Renewal logic adjusted

Signed-off-by: Santhosh Gandhe <1909520+san81@users.noreply.github.com>

# This is the commit message #7:

partial

Signed-off-by: Maxwell Brown <mxwelwbr@amazon.com>

fix merge issues

Signed-off-by: Maxwell Brown <mxwelwbr@amazon.com>

update

Signed-off-by: Maxwell Brown <mxwelwbr@amazon.com>

Add getColumnDataTypes method to SchemaManager to get datatype for table columns (opensearch-project#5135)

Add getColumnDataTypes method to SchemaManager

Signed-off-by: Dinu John <86094133+dinujoh@users.noreply.github.com>

Add model for table column metadata for Global state (opensearch-project#5136)

Signed-off-by: Dinu John <86094133+dinujoh@users.noreply.github.com>

Rename the KDS source plugin name to "kinesis-data-streams" (opensearch-project#5138)

Signed-off-by: Souvik Bose <souvbose@amazon.com>
Co-authored-by: Souvik Bose <souvbose@amazon.com>

Addressed review comments (opensearch-project#5108)

Signed-off-by: Krishna Kondaka <krishkdk@amazon.com>

fixes related to source config properties change

Signed-off-by: Santhosh Gandhe <1909520+san81@users.noreply.github.com>

removed future handling for loop based operations

Signed-off-by: Santhosh Gandhe <1909520+san81@users.noreply.github.com>

additional test cases

Signed-off-by: Santhosh Gandhe <1909520+san81@users.noreply.github.com>

addressing review comments

Signed-off-by: Santhosh Gandhe <1909520+san81@users.noreply.github.com>

Jira Service Test coverage

Signed-off-by: Maxwell Brown <mxwelwbr@amazon.com>

jirasourceconfigTest comments

Signed-off-by: Maxwell Brown <mxwelwbr@amazon.com>

introduced RestClient and moved rest template interactions to there. Similar chage on the test cases too

Signed-off-by: Santhosh Gandhe <1909520+san81@users.noreply.github.com>

backingoff for any kind of exception.

Signed-off-by: Santhosh Gandhe <1909520+san81@users.noreply.github.com>

restructured constants file

Signed-off-by: Santhosh Gandhe <1909520+san81@users.noreply.github.com>

JiraSourceTests

Signed-off-by: Maxwell Brown <mxwelwbr@amazon.com>

JiraItemInfo coverage

Signed-off-by: Maxwell Brown <mxwelwbr@amazon.com>

jira service branch coverage

Signed-off-by: Maxwell Brown <mxwelwbr@amazon.com>

branch coverage jira service

Signed-off-by: Maxwell Brown <mxwelwbr@amazon.com>

move add Items to queue logic into JiraItemInfo

Signed-off-by: Maxwell Brown <mxwelwbr@amazon.com>

fixing regex and adding date time formatter

Signed-off-by: Maxwell Brown <mxwelwbr@amazon.com>

Revert "Jira source"

re add changes and fix issues

Signed-off-by: Maxwell Brown <mxwelwbr@amazon.com>

unneeded comment

Signed-off-by: Maxwell Brown <mxwelwbr@amazon.com>

using issue bean methods to simplify the logic

Signed-off-by: Santhosh Gandhe <1909520+san81@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants