Yahoo convention: empty elements become '' not {}. Fixes #37

sanand0 · Feb 10, 2019 · 09136ab · 09136ab
1 parent f8a0434
commit 09136ab
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/tests/test_xmljson.py b/tests/test_xmljson.py
@@ -576,6 +576,10 @@ def test_data(self):
         }''', object_pairs_hook=Dict)
 
         eq(json.dumps(data), result)
+        eq('{"x": ""}', '<x/>')
+        eq('{"x": "text"}', '<x>text</x>')
+        eq('{"x": {"key": "val"}}', '<x key="val"></x>')
+        eq('{"x": {"key": "val", "content": "text"}}', '<x key="val">text</x>')
 
     def test_xml_fromstring(self):
         'xml_fromstring=False does not convert types'

diff --git a/xmljson/__init__.py b/xmljson/__init__.py
@@ -167,6 +167,9 @@ def data(self, root):
             else:
                 result = value.setdefault(child.tag, self.list())
                 result += self.data(child).values()
+        # if simple_text, elements with no children or attrs become '', not {}
+        if not value and self.simple_text:
+            value = ''
         return self.dict([(root.tag, value)])