Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing root element in parker conversion #13

Closed
wants to merge 1 commit into from

Conversation

stfuchs
Copy link

@stfuchs stfuchs commented Nov 22, 2016

For the parker conversion the root element is ignored. Is this intentional?

@sanand0
Copy link
Owner

sanand0 commented Nov 23, 2016

@stfuchs According to this MDN article the root element is absorbed. That's the design I followed.

But according to this document it isn't.

Is there any authoritative reference to the Parker convention that is still around? Also, could you explain the reason behind choosing the Parker convention? That would help me with the right choice.

@stfuchs
Copy link
Author

stfuchs commented Nov 23, 2016

Ah I see, did not know the convention is unclear on this. To be honest I chose Parker because I don't have xml attributes and it provided the cleanest json in my case. If you want to stick with the convention that absorbs the root element, that's fine with me. A small hint in the readme might be useful though.

@dagwieers
Copy link
Contributor

Maybe it should become optional then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants