Replace Type constructors in env with actual Types #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avaq
commented
Feb 24, 2017
test/env.js
Outdated
| var eq = require('./internal/eq'); | ||
|
|
||
|
|
||
| var $Type = $.NullaryType( |
There was a problem hiding this comment.
It would be nice if sanctuary-def exports Type, so I don't have to create it myself.
There was a problem hiding this comment.
Could we name this Type rather than $Type? Regardless, let's add a type signature. :)
|
If |
|
Could you update this pull request's destination branch to the temporary |
test/env.js
Outdated
| var $ = require('sanctuary-def'); | ||
| var type = require('sanctuary-type-identifiers'); | ||
|
|
||
| var eq = require('./internal/eq'); |
There was a problem hiding this comment.
Let's group the imports like so:
var $ = require('sanctuary-def');
var type = require('sanctuary-type-identifiers');
var S = require('..');
var eq = require('./internal/eq');
test/env.js
Outdated
| test('env', function() { | ||
|
|
||
| eq(typeof S.env, 'object'); | ||
| eq($.test([], $.Array($Type), S.env), true); |
There was a problem hiding this comment.
This is an elegant assertion!
test/env.js
Outdated
| var $Type = $.NullaryType( | ||
| 'sanctuary/Type', | ||
| '', | ||
| function(x) { return type(x) === 'sanctuary-def/Type'; } |
There was a problem hiding this comment.
Did you consider using S.type here?
davidchambers
approved these changes
Feb 26, 2017
This was referenced Feb 26, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on sanctuary-js/sanctuary-def#123
This fixes the inconsistent type of
env, allowing it to be passed into$.test. We should release this as a patch.