share definitions of constraints, types, and functions #514
Conversation
| Sum.Type | ||
| ]) | ||
| }); | ||
| }(require('.'))); |
There was a problem hiding this comment.
We define S here for the benefit of the doctests.
| // createSanctuary :: Options -> Module | ||
| function createSanctuary(opts) { | ||
|
|
||
| /* eslint-disable indent */ |
index.js
Outdated
| createSanctuary); | ||
| function create(opts) { | ||
| var S = { | ||
| env: defaultEnv, |
There was a problem hiding this comment.
This should be opts.env rather than defaultEnv, should it not? If others agree, I'll open a separate pull request for this change.
| S[name] = def(name, _[name].consts, _[name].types, _[name].impl); | ||
| }); | ||
| return S; | ||
| } |
There was a problem hiding this comment.
This function is several thousand lines smaller than createSanctuary. ;)
davidchambers
force-pushed
the
davidchambers/create
branch
3 times, most recently
from
8cd7de9 to
e4e60dd
Compare
|
To make certain I understand, you pulled the definitions out of |
|
Before: function createSanctuary(opts) {
var S = {};
// Sanctuary functions (including ‘create’) defined here.
return S;
}
return createSanctuary({checkTypes: true, env: defaultEnv});
After: // Sanctuary functions (including ‘create’) defined at the top level.
return create({checkTypes: true, env: defaultEnv});
|
|
LGTM |
| //. . ({x, y, width, height}) | ||
| //. . ) | ||
| //. createRect |
davidchambers
force-pushed
the
davidchambers/create
branch
from
3d435a4 to
565195f
Compare
Currently, each Sanctuary function is defined once for each Sanctuary module created. This pull request restructures the code so that constraints, types, and functions are defined just once.