-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reinstate S.unchecked #518
Conversation
index.js
Outdated
@@ -402,7 +406,7 @@ | |||
function create(opts) { | |||
var def = $.create(opts); | |||
var S = { | |||
env: defaultEnv, | |||
env: opts.env, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll open a separate pull request for this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This checks on of the boxes in #471! See #262 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would love to see what you previously suggested included in this commit. It'd make ES6 imports much cleaner.
src/
├── index.js
├── unchecked/
│ ├── index.js
ES5
const $ = require('sanctuary/unchecked')
// or
const { unchecked: $ } = require('sanctuary')
ES6
import $ from 'sanctuary/unchecked'
Without this change, ES6 imports would look like the following in every file:
import sanctuary from 'sanctuary'
const { unchecked: $ } = sanctuary
Would this work, @mwalkerwells? import { unchecked as S_ } from 'sanctuary'; |
Oh duh, yeah that works. 😬 |
That's good to hear, @mwalkerwells! Let's stick with the |
See here for a little discussion on the feature/mistake of node.js automatically resolving |
db8d85b
to
71ddd84
Compare
71ddd84
to
97cbc52
Compare
I think I know which box you have in mind but I'm not certain, so I'll let you check it, Aldwin. :) |
Closes #517
S.unchecked
was removed in #206. Two years later, it's time to bring it back. :)/cc @mwalkerwells