-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lcu implementation #178
lcu implementation #178
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am good with the most of it. Here are some general questions:
- Could
get_truncated_taylor_series
be in a different file as it seems different vs theLCU
? - Is there any justification for the use of
vec = (vecs[:, 0] + vecs[:, 1])/np.sqrt(2)
as the initial state in the tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things. Good work, you make solid use of the tangelo objects and numpy, your documentation and flow looks great as well.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff !
This implements the Linear Combination of Unitaries algorithm.
Both the standard form for any operator and the truncated taylor series form are included.