Remove of deduplicated code #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesB-1qbit
suggested changes
Nov 9, 2021
qsdk/toolboxes/qubit_mappings/symmetry_conserving_bravyi_kitaev.py
Outdated
Show resolved
Hide resolved
ValentinS4t1qbit
approved these changes
Nov 10, 2021
JamesB-1qbit
approved these changes
Nov 12, 2021
ValentinS4t1qbit
approved these changes
Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are the highlights:
_unitary_cc.pyjordan_wigner.pyopenfermion.QubitOperatortoqsdk.QubitOperatorin thefermion_to_qubit_mappingfunction.isinstance(fermion_operator, FermionOperator)->isinstance(fermion_operator, ofFermionOperator)so that those functions work withopenfermion.FermionOperatorand ourFermionOperator._unitary_cc_openshell.pyand_unitary_cc_paired.pyseem to be entirely new files (inspired by_unitary_cc.py), so I kept those.