-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Korean translation (Sandboxie Plus) #2133
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other dependencies to translate / add:
-
1. Here you can find the location of the
Sandboxie Plus
installer languages file where you need to translate the english lines in the [CustomMessages] section -
2. Here you can find the location of the
Sandboxie Plus
installer script where you need to add the language value, for example:'korean': Result := 'ko';
-
3. Upload the Korean unofficial language for InnoSetup in our custom ISL folder
-
4. Add
Name: "korean"; MessagesFile: "isl\Korean.isl"
in the [Languages] section of Languages.iss
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a rule of thumb, you shouldn't ever translate the .ts files by hand, in order to avoid formatting issues (the use of an official translation tool like Qt Linguist
is highly recommended).
Just in case, please take a look at the recommendations chapter in the Localization notes and tips: https://git.io/J9G19
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At this rate we will not make it, please use the official Linguist tool described in the previous guide to check all errors at once instead to wait the reviews one by one (there are more than 5000 lines in sandman_ko.ts).
Once loaded the TS file, the tool will indicate you the entries to fix. It will also help you to prevent any type of formatting issue in future.
EDIT: Explained better in #2133 (review)
Co-authored-by: isaak654 <isaak654@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- We're almost there, now you need to open the TS file. You will see this:
- 1. the esclamation marks in red mean that some element of punctuation is missing. (fixed with 2faa51b)
- 2. the questions marks in yellow mean that you need to mark the translated entries as finished: (fixed with cde0a47)
You can leave some of the entries of which you have doubts as unfinished, but not to leave all entries as unfinished at 100%.
As example, see the animated video below (you can open it in a new tab to restart it):
Feel free to decide the number of entries you want to mark.
👉 #2133 (review) (updated) |
If you have doubts about the remaining task in #2133 (review), I am available for any clarification. |
|
Update sandman_ko.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to be merged, just waiting the CI to be fixed:
@DavidXanatos Make sure to not incur in #1556 after this PR will be merged.
Thank you for your help and thank you for your hard work. |
You're welcome. If you are looking for other ways to contribute:
|
Thank you for your contribution to the Sandboxie repository.
In order to reduce the risk of accidental merges, it's highly recommended for beginners to open a new Pull Request in draft state by clicking the button "Create Draft Pull Request", instead of using the default "Create Pull Request" option.
In addition, you can convert an existing pull request to a draft by clicking the "Convert to draft" link in the right sidebar under "Reviewers".
All new translators are encouraged to look at the "Localization notes and tips" before creating a pull request: https://git.io/J9G19