Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CourseCoreq Hybrid Components in Add Course Modal #806

Closed
wants to merge 27 commits into from

Conversation

liamcarvajal
Copy link
Contributor

@liamcarvajal liamcarvajal commented Feb 6, 2025

Description

Displays combination component for courses and their coreqs in the searching part of the add course modal. It also displays a combination component for courses and their coreqs in the "selected courses" part of the add course modal.

Closes #803

Figma Design

Screenshot 2025-03-05 at 2 06 43 AM

Type of change

Please tick the boxes that best match your changes.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This requires a run of yarn install
  • This has migration changes and requires a run of yarn dev:migration:run

How Has This Been Tested?

Please describe how you tested this PR (both manually and with tests) Provide instructions so we can reproduce.

  • Test A
  • Test B

Checklist:

  • I have run the production builds in docker for the frontend/backend and ensure things run fine. Check README of repo on how to run if not sure.
  • I have performed a self-review of my own code
  • I have commented my code where needed
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I've run the end to end tests
  • Any dependent changes have been merged and published in downstream modules

Copy link

vercel bot commented Feb 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
graduatenu-frontend-v2 ❌ Failed (Inspect) Mar 16, 2025 7:16pm

Ameeka-Patel and others added 3 commits February 6, 2025 15:43
only include coreqs for classes that have 4 or more credits
Ameeka-Patel and others added 3 commits February 25, 2025 19:11
only include coreqs for classes that have 4 or more credits
@liamcarvajal liamcarvajal changed the title attempt at course-coreq hybrid search result w dropdown CourseCoreq Hybrid Components in Add Course Modal Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants