Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with Master #5

Merged
merged 18 commits into from
Jan 6, 2020
Merged

Sync with Master #5

merged 18 commits into from
Jan 6, 2020

Conversation

sandeep-paliwal
Copy link
Owner

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

sandeep-paliwal and others added 18 commits December 2, 2019 09:50
Trivial documentation update
Trivial documentation update
Trivial documentation update
Trivial documentation update
* update dotenv

* update app scripts version

* update scripts v again
* chore(package): update jest-junit to version 10.0.0

* chore(package): update jest-junit to version 10.0.0

* fix(package): update jest-junit to version 10.0.0

* chore(package): update jest-junit to version 10.0.0
* Respect user provided packageName

* fix whitespace diff
* aio app run launches web-src with https
* reads package.json for app name, generates cert if dne
* handle missing cert plugin
Co-authored-by: Shazron Abdullah <shazron@gmail.com>
@codecov-io
Copy link

codecov-io commented Jan 6, 2020

Codecov Report

Merging #5 into master will decrease coverage by 0.88%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #5      +/-   ##
=========================================
- Coverage   88.28%   87.4%   -0.89%     
=========================================
  Files          10      10              
  Lines         239     254      +15     
  Branches       34      37       +3     
=========================================
+ Hits          211     222      +11     
- Misses         24      28       +4     
  Partials        4       4
Impacted Files Coverage Δ
src/commands/app/logs.js 25% <ø> (ø) ⬆️
src/commands/app/run.js 85.36% <75%> (-6.95%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1558cc3...f7e5bde. Read the comment docs.

@sandeep-paliwal sandeep-paliwal merged commit d0ee425 into sandeep-paliwal:master Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants