Force LDO option set or unset

[zbx-sadman]

Some remote clients needs LDO using on any Spreading Factor. CDEbyte E32 (and similar) modules for example.

[sandeepmistry]

Hi @zbx-sadman,

Thanks for taking the time to open this pull request, what do think about splitting the API to enableLowDataRateOptimize() and disableLowDataRateOptimize()?

[zbx-sadman]

Hello @sandeepmistry

Library author known better how to make his code pretty and readable, i guess.

Honestly, i modified source a bit deeper and it can be written now as follows:

LoRa.h

class LoRaClass : public Stream {
public:
  LoRaClass();
...
  void setLdoFlagForced(const boolean);  // can be replaced with enableLowDataRateOptimize() & disableLowDataRateOptimize()
  void enableLowDataRateOptimize();
  void disableLowDataRateOptimize();
...
private:
...
  boolean _ldoForced;
...
};

LoRa.cpp

void LoRaClass::setLdoFlag()
{
  boolean ldoOn = true;

  if (!_ldoForced) {
     // Section 4.1.1.5
     long symbolDuration = 1000 / ( getSignalBandwidth() / (1L << getSpreadingFactor()) ) ;

     // Section 4.1.1.6
     ldoOn = symbolDuration > 16;
  }

  uint8_t config3 = readRegister(REG_MODEM_CONFIG_3);
  bitWrite(config3, 3, ldoOn);
  writeRegister(REG_MODEM_CONFIG_3, config3);
}

// can be replaced with enableLowDataRateOptimize() & disableLowDataRateOptimize()
void LoRaClass::setLdoFlagForced(const boolean ldoForced)
{
  _ldoForced = ldoForced; 
  setLdoFlag();
}

void LoRaClass::enableLowDataRateOptimize() 
{
  _ldoForced = true; 
  setLdoFlag();
}

void LoRaClass::disableLowDataRateOptimize() 
{
  _ldoForced = false; 
  setLdoFlag();
}

Let me know if i must create another pull-request.

Thanks for your helpful library.

[sandeepmistry]

Hi @zbx-sadman,

Thanks for considering the feedback, I would suggest making the void setLdoFlagForced(const boolean); private, and removing _ldoForced. Other than your comments in #668 (comment) look good. Feel free to make edits to this pull request or make a new one.

[zbx-sadman]

Hello @sandeepmistry, i've add separated setter methods for LDO flag.
This is right way for library?

[sandeepmistry]

@zbx-sadman yes, that looks good. I've pushed some minor changes in 1928aab to update the keywords.txt and move the private function declaration in the .h earlier in the file.