Fix persistence of more image adjustment settings: brightness, contrast, and opacity #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file dialog to select a labels reference file defaults to the current working directory. To set the default directory to the current image's directory, a separate file dialog must be set rather than using the TraitsUI FileEditor. Implement a Pyface file dialog triggered by a new button, similar to the figure save button, with default directory set to that of the image.
Brightness and contrast adjustments operate on the original image to avoid creating a feedback loop from changes. After adjusting brightness, however, any adjustment to contrast wipes out the brightness change and vice versa. Fix by including both brightness and contrast values when making adjustments to either to provide the current baseline for each value when adjusting the original image.
…through planes - Reuse the opacity value from the last displayed image - Store and reuse brightness and contrast values when adjusting them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #76 fixed persistence of both auto and manual intensity settings in the image adjustment panel, but opacity, brightness, and contrast settings are still reset when scrolling through images. This PR makes these settings persistent while scrolling through a given image.
Additionally, the brightness and contrast settings have conflicted with one another, where adjusting one caused the other setting to be ignored. The brightness and contrast settings both operate on the original image, meaning that they need to know any changes to the other setting to reapply it when making any adjustments. This PR fixes the settings by applying both brightness and contrast together with any change to one value.