Update setup-kubetools.sh

[dmbrownlee]

Current sed line breaks /etc/fstab as it puts the '#' between '/' and "swap". Instead, match the fstype field ("swap" surrounded by spaces) and prepend a '#' to the beginning of the line if it does not already start with one (idempotent ;) ).

[dmbrownlee]

Not sure if you take pull requests. You'll also need to make this change in the other setup files.

Consider also removing "sudo" as you check for the root user at the start of the script.

[sandervanvugt]

Fixed! Thanks for your feedback.

…

On 30 Mar 2023, at 22:45, D. M. Brownlee ***@***.***> wrote: Not sure if you take pull requests. You'll also need to make this change in the other setup files. Consider also removing "sudo" as you check for the root user at the start of the script. — Reply to this email directly, view it on GitHub <#15 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AG3TNVULRCAHCEKC2ET5HZ3W6XWGJANCNFSM6AAAAAAWNZS6HM>. You are receiving this because you are subscribed to this thread.

[gitguardian]

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
14152886	Triggered	Generic CLI Secret	b0669a2	history-14Oct24.txt	View secret

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code.
2. Replace and store your secret safely. Learn here the best practices.
3. Revoke and rotate this secret.
4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

• following these best practices for managing and storing secrets including API keys and other credentials
• install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

---

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}