Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compile warnings in tests/imf.c #18

Closed
palemieux opened this issue Jun 16, 2021 · 0 comments · Fixed by #19
Closed

Compile warnings in tests/imf.c #18

palemieux opened this issue Jun 16, 2021 · 0 comments · Fixed by #19
Assignees
@valnoel
Labels
bug Something isn't working
Milestone
Model, Module, as...

Comments

@palemieux
Copy link
Contributor 

libavformat/tests/imf.c:204:12: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
 static int test_cpl_parsing() {
            ^~~~~~~~~~~~~~~~
libavformat/tests/imf.c:283:12: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
 static int test_asset_map_parsing() {
            ^~~~~~~~~~~~~~~~~~~~~~
@palemieux palemieux added the bug Something isn't working label Jun 16, 2021
valnoel added a commit that referenced this issue Jun 18, 2021
@valnoel
Fix IMF tests function prototypes (#18)
c42de04
@valnoel valnoel mentioned this issue Jun 18, 2021
Merged
@valnoel valnoel self-assigned this Jun 18, 2021
palemieux added a commit that referenced this issue Jun 23, 2021
@palemieux
Remove unit tests compilation warnings (#18)
8d8802b
MarcAntoine-Arnaud pushed a commit that referenced this issue Aug 10, 2021
@valnoel @MarcAntoine-Arnaud
Fix IMF tests function prototypes (#18)
f25a602
MarcAntoine-Arnaud pushed a commit that referenced this issue Aug 10, 2021
@valnoel @MarcAntoine-Arnaud
Fix IMF tests function prototypes (#18)
3a7ef50
palemieux pushed a commit that referenced this issue Sep 8, 2021
@valnoel @palemieux
Fix IMF tests function prototypes (#18)
728ad1a
palemieux pushed a commit that referenced this issue Sep 8, 2021
@valnoel @palemieux
Fix IMF tests function prototypes (#18)
890ae84
palemieux pushed a commit that referenced this issue Sep 10, 2021
@valnoel @palemieux
Fix IMF tests function prototypes (#18)
6de4635
valnoel added a commit that referenced this issue Sep 23, 2021
@valnoel
Fix IMF tests function prototypes (#18)
1df4832
palemieux pushed a commit that referenced this issue Sep 29, 2021
@valnoel @palemieux
Fix IMF tests function prototypes (#18)
03dc4b2
palemieux pushed a commit that referenced this issue Oct 18, 2021
@valnoel @palemieux
Fix IMF tests function prototypes (#18)
23e6219
palemieux pushed a commit that referenced this issue Nov 4, 2021
@valnoel @palemieux
Fix IMF tests function prototypes (#18)
004b364
palemieux pushed a commit that referenced this issue Nov 23, 2021
@valnoel @palemieux
Fix IMF tests function prototypes (#18)
820f8e3
palemieux pushed a commit that referenced this issue Nov 25, 2021
@valnoel @palemieux
Fix IMF tests function prototypes (#18)
14b1c3f
palemieux pushed a commit that referenced this issue Dec 17, 2021
@Yuyang14 @michaelni
libswresample/swresamplec: Err num(negative-size) was used as a funct…
ac2b34a 
…ion parameter

If memory allocation fails, ERROR(ENOMEM) '-12' will be returned.
When resample() is done first, the negative size param would cause buffer-overflow and SEGV in swri_rematrix().
When swri_rematrix() is run first, resample() would not cause an error but Err num as a wrong parameter passing.
Err num should be returned immediately. And remove an unneeded term from an assert.

coredump info:
    #0 0x499517 in posix_memalign (/home/r1/ffmpeg/ffmpeg_4.4.1+0x499517)
    #1 0x6c1f0b4 in av_malloc /home/r1/ffmpeg/ffmpeg-4.4.1/build/src/libavutil/mem.c:86:9
    #2 0x6c208fe in av_mallocz /home/r1/ffmpeg/ffmpeg-4.4.1/build/src/libavutil/mem.c:239:17
    #3 0x6c207ad in av_mallocz_array /home/r1/ffmpeg/ffmpeg-4.4.1/build/src/libavutil/mem.c:195:12
    #4 0x654b2e5 in swri_realloc_audio /home/r1/ffmpeg/ffmpeg-4.4.1/build/src/libswresample/swresample.c:418:14
    #5 0x654f9a1 in swr_convert_internal /home/r1/ffmpeg/ffmpeg-4.4.1/build/src/libswresample/swresample.c:601:17
    #6 0x654d2c0 in swr_convert /home/r1/ffmpeg/ffmpeg-4.4.1/build/src/libswresample/swresample.c:766:19
    #7 0x186cf56 in flush_frame /home/r1/ffmpeg/ffmpeg-4.4.1/build/src/libavfilter/af_aresample.c:251:13
    #8 0x186a454 in request_frame /home/r1/ffmpeg/ffmpeg-4.4.1/build/src/libavfilter/af_aresample.c:288:20
    #9 0x787d9c in ff_request_frame_to_filter /home/r1/ffmpeg/ffmpeg-4.4.1/build/src/libavfilter/avfilter.c:459:15
    #10 0x7877f1 in forward_status_change /home/r1/ffmpeg/ffmpeg-4.4.1/build/src/libavfilter/avfilter.c:1257:19
    #11 0x77ed7e in ff_filter_activate_default /home/r1/ffmpeg/ffmpeg-4.4.1/build/src/libavfilter/avfilter.c:1288:20
    #12 0x77e4e1 in ff_filter_activate /home/r1/ffmpeg/ffmpeg-4.4.1/build/src/libavfilter/avfilter.c:1441:11
    #13 0x793b3f in ff_filter_graph_run_once /home/r1/ffmpeg/ffmpeg-4.4.1/build/src/libavfilter/avfiltergraph.c:1403:12
    #14 0x7a7bee in get_frame_internal /home/r1/ffmpeg/ffmpeg-4.4.1/build/src/libavfilter/buffersink.c:131:19
    #15 0x7a7287 in av_buffersink_get_frame_flags /home/r1/ffmpeg/ffmpeg-4.4.1/build/src/libavfilter/buffersink.c:142:12
    #16 0x792888 in avfilter_graph_request_oldest /home/r1/ffmpeg/ffmpeg-4.4.1/build/src/libavfilter/avfiltergraph.c:1356:17
    #17 0x5d07df in transcode_from_filter /home/r1/ffmpeg/ffmpeg-4.4.1/build/src/fftools/ffmpeg.c:4639:11
    #18 0x59e557 in transcode_step /home/r1/ffmpeg/ffmpeg-4.4.1/build/src/fftools/ffmpeg.c:4729:20
    #19 0x593970 in transcode /home/r1/ffmpeg/ffmpeg-4.4.1/build/src/fftools/ffmpeg.c:4805:15
    #20 0x58f7a4 in main /home/r1/ffmpeg/ffmpeg-4.4.1/build/src/fftools/ffmpeg.c:5010:9
    #21 0x7f6fd2dee0b2 in __libc_start_main /build/glibc-eX1tMB/glibc-2.31/csu/../csu/libc-start.c:308:16

SUMMARY: AddressSanitizer: negative-size-param (/home/r1/ffmpeg/ffmpeg_4.4.1+0x497e67) in __asan_memcpy

Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
palemieux pushed a commit that referenced this issue Dec 17, 2021
@valnoel @palemieux
Fix IMF tests function prototypes (#18)
1ae5184
palemieux pushed a commit that referenced this issue Dec 18, 2021
@valnoel @palemieux
Fix IMF tests function prototypes (#18)
d7bbc2b
palemieux pushed a commit that referenced this issue Aug 23, 2022
@rgonzalezfluendo @elenril
avformat: allow .ec3 as extension for raw E-AC-3 stream
2d8d7f8 
In addition to .eac3, .ec3 is also commonly used by people to name raw
E-AC-3 streams. Enables automatic recognition of the eac3 format for
the .ac3 extension.

For instance Dolby Digital Plus software only support files with
.ec3. Files with .eac3 are not supported. Check issue #18 in the
public dlb_mp4base repository from DolbyLaboratories.

Signed-off-by: Ruben Gonzalez <rgonzalez@fluendo.com>
Signed-off-by: Anton Khirnov <anton@khirnov.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valnoel valnoel

Labels
bug Something isn't working
Projects
None yet
Milestone
Model, Module, asset locator and asse...
Development

Successfully merging a pull request may close this issue.

Remove IMF unit tests compile warnings sandflow/ffmpeg-imf
2 participants
@valnoel @palemieux