Skip to content

Added initial Boyle/Coello soiling model #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 27, 2019
Merged

Added initial Boyle/Coello soiling model #26

merged 4 commits into from
Jun 27, 2019

Conversation

DanRiley
Copy link
Collaborator

Closes #25.

@DanRiley
Copy link
Collaborator Author

I thought I should let you know, @wholmgren, that I'd implemented a new soiling model in MATLAB.

@wholmgren
Copy link

Thanks @DanRiley!

@wholmgren wholmgren mentioned this pull request Jun 24, 2019
Closed
cwhanse
cwhanse requested changes Jun 25, 2019
View reviewed changes
Copy link
Collaborator

@cwhanse cwhanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edits to signature and some typos.

cwhanse
cwhanse approved these changes Jun 26, 2019
View reviewed changes
Copy link
Collaborator

@cwhanse cwhanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge @DanRiley ?

@DanRiley
Copy link
Collaborator Author

I think so. After updating the reference to the IEEE JPV, I don't have any other changes.

@cwhanse cwhanse merged commit e52dd76 into sandialabs:master Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwhanse cwhanse cwhanse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: soiling model
3 participants
@DanRiley @wholmgren @cwhanse