-
Notifications
You must be signed in to change notification settings - Fork 24
consistent use xr.DataArray and xr.Dataset arguments #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 6747692411
💛 - Coveralls |
Solve docstring should be fixed now @cmichelenstrofer |
@jtgrasb - I think this may also need to be updated for the static methods for creating Lines 511 to 561 in 6c9b852
We should get consistent with this, or (ideally) program in a way that is agnostic to whether the users passes an |
@ryancoe I changed the title of this PR as it was backwards previously. The PR makes exc_coeff an ArrayLike input wherever it is used. The ArrayLike specification is agnostic to whether the users passes an |
Per discussion today: we like indexing by name, so require the arguments to be |
Description
This pull request makes the
exc_coeff
to be consistently aDataArray
throughout the multiple functions that use it. I also briefly checked some of the other docstrings to confirm inputs and outputs are accurately recorded.Closes #183
Type of PR
Checklist for PR
Additional details
This is in response to issue #183. @akeow I don't know what caused the initial issue so please let me know whether this solves the issue.