Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jupyter-notebook dependency #41

Merged
merged 18 commits into from
Feb 1, 2022
Merged

jupyter-notebook dependency #41

merged 18 commits into from
Feb 1, 2022

Conversation

ryancoe
Copy link
Collaborator

@ryancoe ryancoe commented Feb 1, 2022

Description

Fixes #40 and explicitly specifies versions for dependencies

Type of PR

  • Bug fix
  • Major change
  • New feature

Checklist for PR

Additional details

Include any relevant context and describe any validation and verification efforts.

@ryancoe ryancoe added the bug Something isn't working label Feb 1, 2022
@ryancoe ryancoe self-assigned this Feb 1, 2022
@ryancoe
Copy link
Collaborator Author

ryancoe commented Feb 1, 2022

@cmichelenstrofer - I'm having second thoughts about the wisdom of pinning versions for all the dependencies... bb424fa is pretty loose with this, but I still worry that it will lead to dependency conflicts for people. There's a good discussion here: https://stackoverflow.com/questions/28509481/should-i-pin-my-python-dependencies-versions

There also some tools for getting notifications when dependencies have new versions: https://requires.io

What do you think?

@cmichelenstrofer
Copy link
Member

@ryancoe I agree, I prefer to not specify a version unless we have to (e.g. minimum version required). If something breaks it becomes very obvious (specially with our CI tests) and we can fix it quickly. I do get that dealing with dependencies can be annoying to new Python users, though. But it is a part of Python.

@ryancoe ryancoe changed the title update dependencies jupyter-notebook dependency Feb 1, 2022
Copy link
Member

@cmichelenstrofer cmichelenstrofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some small changes.

@ryancoe ryancoe marked this pull request as ready for review February 1, 2022 22:17
@ryancoe ryancoe merged commit 9e26ea0 into sandialabs:main Feb 1, 2022
@ryancoe ryancoe deleted the update_deps branch February 2, 2022 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: install does not give "jupiter-notebook"
2 participants