-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jupyter-notebook dependency #41
Conversation
based on macOS 10.15, hopefully works for everyone though
@cmichelenstrofer - I'm having second thoughts about the wisdom of pinning versions for all the dependencies... bb424fa is pretty loose with this, but I still worry that it will lead to dependency conflicts for people. There's a good discussion here: https://stackoverflow.com/questions/28509481/should-i-pin-my-python-dependencies-versions There also some tools for getting notifications when dependencies have new versions: https://requires.io What do you think? |
@ryancoe I agree, I prefer to not specify a version unless we have to (e.g. minimum version required). If something breaks it becomes very obvious (specially with our CI tests) and we can fix it quickly. I do get that dealing with dependencies can be annoying to new Python users, though. But it is a part of Python. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some small changes.
Description
Fixes #40 and
explicitly specifies versions for dependenciesType of PR
Checklist for PR
Additional details
Include any relevant context and describe any validation and verification efforts.