Bugfix numpy deprecations #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 20, 2022 14:27
Performs an initial round of numpy dtype updates to handle the deprecated aliases that were phased out in numpy 1.24.0
There are some deprecated dtype calls in the qibo codebase that are breaking the import on numpy 1.24.0, so catch this exception and skip this test if necessary.
Adds an additional catch for the attribute error that is being raised on import for qibo.
sserita
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took an initial pass at fixing the calls to the newly deprecated dtype aliases. I think I got everything in our codebase, but there are some broken calls in qibo that cause the import to die, and related unit tests to fail, so these have been temporarily disabled. There are a couple more unit tests that are failing, but these are related to germ selection and seem to be broken for a different reason (I suspect for a disjoint numpy change given the error messages). For the sake of having a clean commit history I am going to fix those problems on another branch where I also look into the edge case @enielse showed me about when the initial set of germs in germ selection is empty. So I'm requesting we merge this in even though there are still some failing tests.