-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Help pytest find tests #362
Conversation
…ional dependency csaps is missing.
Documenting where I am on this. Here are the currently failing tests.
|
…were really incomplete base classes.
It seems that all failing tests mentioned in my last comment where due to incomplete classes having the |
IMO this is ready to merge. |
Thanks, I'll try to look at this in the next few days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the nice work!
This should resolve #361.
This branch has latest develop as its base. It had 6 failing tests when I started. Five of those failing tests were due to a wrong version of a dependency (qibo) I got when I installed pyGSTi. The other failing test was due to a missing dependency. I've modified this last failing test so that it handles the missing dependency gracefully. I'd like it if the other five tests also gracefully handled a wrong dependency version, but I'll put that off for now as issue #363.
The initial change I made in this PR was just to
pytest.ini
. Then I needed to fix some broken tests.