Bugfix germsel correctness tests #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 9, 2024 17:15
Add additional possible solutions to the correctness checks.
Add in some more candidate solutions.
Print some additional diagnostic info on the runners.
Print some on-runner diagnostic information.
Add another candidate solution for greedy germ search.
sserita
approved these changes
Jan 24, 2024
|
I merged this in now because these tests were now the failing ones on beta. I'd like to get a clean set of tests before merging in other branches in for the release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the germ selection correctness/integration checks added to the unit tests in
test_packagesin a recent update to develop. These tests can be sensitive to various difference among OS and python version and so were failing on some runners. Additional solutions have been added to the tests to account for these local variations, and we now have all of the tests in thetest_packagesworkflow passing. With the exception of python 3.11 on macOS which is failing because of an unrelated build error with CVXOPT.Note: New commits are 52a793d and onward. The other commits are from the bugfix-stricter-line... branch which has already been merged in, but they still seem to show in the history as new in this branch.It is because I had accidentally selected to merge into master, fixed now.