WIP: Replace dot with infix matmul #433
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not needed and which were only correct for real inputs). Replace the np.trace(np.dot(...)) pattern for computing the trace inner product with np.vdot(...). Use of np.vdot has a secondary affect of conjugating the first argument when dealing with complex inputs, which resolves a limitation of basis conversion discussed in an email thread.
This reverts commit 9a1773e.
|
Closing since we decided to fix this incrementally, rather than with a monolithic PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch originated from a branch with other changes. Many of the changes that Git is reporting are really because of the changes on that root branch.
The main file to look at is here: https://github.com/sandialabs/pyGSTi/blob/5db06722510b0eb70c0443bbd45cb384fffa72f1/scripts/matmul_converter.py.
I used it to produce changes here: 9a1773e, which I've subsequently reverted.
See discussion in #398.