-
Notifications
You must be signed in to change notification settings - Fork 14
Changes output['params'] from tuple to dict, enhancing output express… #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes output['params'] from tuple to dict, enhancing output express… #238
Conversation
…iveness and ability to pass output['params'] to cp_als() by unpacking operator **.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. A similar few small requests and this also looks good to be merged by @dmdunla
I do not understand the workflow here. This is merging a forked branch into a pyttb branch, but there is no pyttb PR to merge that branch: |
@jeremy-myers and @ntjohnson1 WARNING: I'm going to change the target branch for this PR from 236 to main, but it says that commits may be dropped. @jeremy-myers The target branch for PRs should be |
@jeremy-myers, @ntjohnson1 FYI, here's the warning I see: |
I think it's a |
@ntjohnson1 Except for the conflict? 😅 |
... oops. It should be fixed now. Hopefully that didn't spam too many emails. |
…iveness and ability to pass output['params'] to cp_als() by unpacking operator **.
📚 Documentation preview 📚: https://pyttb--238.org.readthedocs.build/en/238/