Use Explicit Atomics In The Internal Spinlock #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still tracking some unusual bugs that are likely related to this so I'm converting it to a draft for now. |
insertinterestingnamehere
changed the base branch from
main
to
release-1.20-pre
insertinterestingnamehere
force-pushed
the
spinlock_atomics
branch
from
1de43b1
to
45b86dc
Compare
insertinterestingnamehere
force-pushed
the
spinlock_atomics
branch
from
45b86dc
to
2dd8e28
Compare
insertinterestingnamehere
force-pushed
the
spinlock_atomics
branch
from
2dd8e28
to
a05ad28
Compare
|
Okay, it looks like the other issues were resolved by other patches at this point. This one's good to go too. @janciesko can you review this one when you get a minute? |
…omic loads and stores in the memory pool.
|
Throwing in a small fix for an intermittent race condition in this same section of code since it wouldn't make any sense without the context of this patch too. |
insertinterestingnamehere
merged commit 8a9e604
into
sandialabs:release-1.20-pre
173 of 297 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #190.