-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Section traces #26
Section traces #26
Conversation
93e7713
to
b7e56a9
Compare
6dbf795
to
08318d1
Compare
Codecov Report
@@ Coverage Diff @@
## develop #26 +/- ##
===========================================
+ Coverage 89.55% 90.97% +1.42%
===========================================
Files 8 8
Lines 1254 1441 +187
===========================================
+ Hits 1123 1311 +188
+ Misses 131 130 -1
Continue to review full report at Codecov.
|
d1dddf2
to
bb4f4c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice stuff, the passing of the *args/**kwargs for the plotting is handy to have.
Ran into a minor issue with the origin of the radial section, but hopefully that is minor. Similarly I had a small suggestion about the L0
identification method and where/how it could be used.
…dy instantiated Section.
Develop new section types. Principally add effective
PathSection
, and theCircularSection
andRadialSection
types. There is still more to do here, but I have opened issues for the main points.Todo
DipSection
or open an issuexarray
) not just indices. Open an issue to address this after Jay's Xarray support #23