Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Section traces #26

Merged
merged 14 commits into from
Oct 26, 2020
Merged

Section traces #26

merged 14 commits into from
Oct 26, 2020

Conversation

amoodie
Copy link
Contributor

@amoodie amoodie commented Sep 15, 2020

Develop new section types. Principally add effective PathSection, and the CircularSection and RadialSection types. There is still more to do here, but I have opened issues for the main points.

Todo

  • finish implementation for RadialSection angles
  • finish tests for RadialSection
  • implement the DipSection or open an issue
  • can the optional argument be streamlined better (simpler)? Open an issue
  • section arguments need to work for actual dimensions of the arrays (xarray) not just indices. Open an issue to address this after Jay's Xarray support #23

@codecov-io
Copy link

codecov-io commented Oct 20, 2020

Codecov Report

Merging #26 into develop will increase coverage by 1.42%.
The diff coverage is 99.50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #26      +/-   ##
===========================================
+ Coverage    89.55%   90.97%   +1.42%     
===========================================
  Files            8        8              
  Lines         1254     1441     +187     
===========================================
+ Hits          1123     1311     +188     
+ Misses         131      130       -1     
Impacted Files Coverage Δ
deltametrics/section.py 98.36% <98.92%> (+1.39%) ⬆️
deltametrics/utils.py 87.64% <100.00%> (+19.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57da003...27142cb. Read the comment docs.

@amoodie amoodie marked this pull request as ready for review October 20, 2020 21:59
@amoodie amoodie requested a review from elbeejay October 21, 2020 02:04
@amoodie amoodie added enhancement New feature or request section labels Oct 21, 2020
@amoodie amoodie added this to the section api milestone Oct 21, 2020
Copy link
Contributor

@elbeejay elbeejay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice stuff, the passing of the *args/**kwargs for the plotting is handy to have.

Ran into a minor issue with the origin of the radial section, but hopefully that is minor. Similarly I had a small suggestion about the L0 identification method and where/how it could be used.

deltametrics/section.py Outdated Show resolved Hide resolved
deltametrics/section.py Outdated Show resolved Hide resolved
deltametrics/section.py Outdated Show resolved Hide resolved
deltametrics/utils.py Show resolved Hide resolved
@amoodie amoodie merged commit bbf3fb1 into sandpiper-toolchain:develop Oct 26, 2020
@amoodie amoodie deleted the section_traces branch March 20, 2022 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants