Refactor certain requirements #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandrogauci
requested changes
Aug 27, 2024
There was a problem hiding this comment.
Thanks for the changes! All changes look very good except for one minor request. Under "Signalling", I suggest that we remove the "as discussed in the previous section" since to avoid giving the impression that signalling and media are very similar. They are very different protocols, often handled by different servers/applications.
Otherwise - its great. Thanks for this refactor, it makes it much easier for us :)
|
Ok so how about this change which splits the guidance: |
sandrogauci
added a commit
that referenced
this pull request
Aug 28, 2024
* define acronyms where possible * slash replaced with "or" * Refactor certain requirements (#1) * Refactor certain requirements * Split guidance for malformed messages and packets --------- Co-authored-by: Josh Grossman <tghosth@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.