Implement Identity.getProfile(). #2452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows grains to retrieve up-to-date profile information on their users, even for users who have not visited the grain in a long time, and even for users who have never visited the grain at all (as may happen if the grain powerbox-requests an identity).
After this change, a grain can have a very simple user database consisting of a map from identity ID to Identity sturdyref, where
SandstormApi.restore()andIdentity.getProfile()are called whenever a particular user's profile is needed.I have tested this change on a branch of the Collections app that implements an "added-by" column.