Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Show OTP secret code at setup after login and in backend module #33

Merged

Conversation

JamesAlias
Copy link
Contributor

@JamesAlias JamesAlias commented Aug 9, 2024

Screen.Recording.2024-08-09.at.3.21.54.PM.mov
Screen.Recording.2024-08-09.at.3.22.40.PM.mov

@JamesAlias JamesAlias force-pushed the feature/show-otp-secret-code-when-creating-new-second-factor branch from 07897ca to a58686d Compare August 12, 2024 13:04
@JamesAlias JamesAlias changed the title TASK: Show OTP setup code in SetupSecondFactor page (after login) TASK: Show OTP secret code at setup after login and in backend module Aug 12, 2024
@JamesAlias JamesAlias changed the title TASK: Show OTP secret code at setup after login and in backend module FEATURE: Show OTP secret code at setup after login and in backend module Aug 12, 2024
@JamesAlias JamesAlias marked this pull request as ready for review August 12, 2024 13:22
@Benjamin-K
Copy link
Contributor

Looks fine by reading. But haven't tested it yet.

@JamesAlias JamesAlias force-pushed the feature/show-otp-secret-code-when-creating-new-second-factor branch from dfe0243 to acf2729 Compare September 26, 2024 08:44
@JamesAlias
Copy link
Contributor Author

Because of different styles between basic neos and neos backend modules, I had to introduce some css specificity hacks with !important.

@JamesAlias JamesAlias merged commit c5c4792 into main Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Show code to allow adding a second factor with devices without camera
3 participants