Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix modifier manager capabilities deprecation #112

Merged
merged 2 commits into from
May 29, 2021
Merged

Fix modifier manager capabilities deprecation #112

merged 2 commits into from
May 29, 2021

Conversation

sandydoo
Copy link
Owner

@sandydoo sandydoo commented May 29, 2021 •
edited
Loading

  • Replace @ember/render-modifiers with a simple did-insert modifier.
  • Use the updated ember-modifier package with support for the new modifier capabilities.

Fixes #102.

sandydoo added 2 commits May 29, 2021 19:46
@sandydoo
Fix modifier manager capabilities deprecation
3e1ee3f 
- Replace `@ember/render-modifiers` with a simple `did-insert` modifier.
- Use the updated `ember-modifier` with support for the new modifier
  capabilities.
@sandydoo
Add test for did-insert modifier
5789851
@sandydoo sandydoo added the bug Something isn't working label May 29, 2021
@sandydoo sandydoo merged commit 57b8ef9 into main May 29, 2021
@sandydoo sandydoo deleted the fix-modifier-manager-deprecation branch May 29, 2021 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Versions of modifier manager capabilities prior to 3.22 have been deprecated.
1 participant
@sandydoo