Return the google global from the API service if Google Maps has already been loaded
#140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @grodriguez85! I'll merge this after I get the CI working. Ember@4.0 is also in beta, so, naturally, the CI is choking on errors 😓 |
|
@grodriguez85, would you mind rebasing your branch on main? |
|
Sure, now it's rebased. |
sandydoo
changed the title
google global from the API service if Google Maps has already been loaded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the GoogleMapsApiService, the _getApi() should return window.google, not window.google.maps right?
After I install the ember-place-autocomplete addon this one is failing to load the Google Maps API. The _loadAndInitApi() function resolves window.google after it loads, and the getter directionsService() tries to access the .maps property. So returning window.google.maps on _getAPI() fails on the getter as it tries to access the maps property by a second time. I think this is a bug added like 4 months ago.
I don't know why the tests are failing, looks like the tests don't have an API Key set.