Fix support for newer versions of Embroider #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v4 seems to set an incorrect version for the modifier capabilities.
I've removed the dynamic component override from the test setup that would fetch the public API from the component. This is now fetched in the GMap component itself in debug mode.
This in-repo addon is used for testing and is dynamically removed from the addon tree when not needed. Embroider is now failing to rebuild the app on changes because it's expecting files from this addon to be present. I've removed the addon from package.json and disabled the test for now. We'll have to migrate to the v2 addon format at some point and reintegrate the test.
sandydoo
force-pushed
the
update-ember
branch
2 times, most recently
from
1353a55 to
e4fa1c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #171.