Add finer grained control over de-registration of a component from the publicAPI proxy #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39 . By making this change, we give addon authors a chance to interact with the map and do any needed tear down prior to tearing down the component registration with our publicAPI proxy while still using exclusively our
publicAPI. Amapproperty does currently exist on theMapComponentand children, but our naming implies that it might not in the future.@sandydoo I'm happy to add some tests here if we want (doing that using an in-repo addon starts looking quite appealing 😉 ), but wanted to push this up to get your input on it before working up the tests.