Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

Dockerfile and addition of optional commands #6

Merged
merged 9 commits into from
Jul 8, 2019

Conversation

trstickland
Copy link
Collaborator

  • Adds a Dockerfile
  • Script now accepts a command, gffmunger [options] [command], that defines action to take; currently has only one function, to move annotations from polypeptide to mRNA (or other parent), and defaults to this if no command is specified. So ATM there's no extra functionality, but it provides a framework for adding new commands that invoke functions.

Copy link

@puethe puethe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
I'd recommend adding minimum versions for your dependencies in setup.py.

@trstickland
Copy link
Collaborator Author

Interesting question about dependencies. I've only tested with up to date versions, but have no reason to think old versions won't work. If I make the current version as a requirement, it prevents an install with older versions (and potentially introduces a conflict) when that may be unnecessary :-/

@puethe
Copy link

puethe commented Jul 8, 2019

It's your decision in the end. I just noticed it as I had to recently raise the pyyaml version in chado-tools as some functionality I use was only added in in version 5 or so.

@trstickland
Copy link
Collaborator Author

could do with syntax for "warn user package version hasn't been tested if < n" ;)

@trstickland trstickland merged commit 2567fa4 into sanger-pathogens:master Jul 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants