Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes tests #49

Merged
merged 5 commits into from
Apr 1, 2015
Merged

Fixes tests #49

merged 5 commits into from
Apr 1, 2015

Conversation

bewt85
Copy link
Contributor

@bewt85 bewt85 commented Apr 1, 2015

Fixes:

  • test created phylip files but listed the sequences in a different order than expected. This shouldn't fail the test so I sort the results before comparing them
  • likewise, when it searched for some files, they were returned in a different order than expected, so I fixed it
  • finally there was a problem that threads weren't being killed during a test and it was causing the test to return more than once.

I've added a String::Util dependency so that I can remove whitespace during the first fix. I'm not sure if I need to record this somewhere or if dzil just picks it up auto-magically.

I'm also not sure what I need to do to bump the version / release / publish this? Given that it wouldn't install for me without a --force because of the failing tests, it would be nice to share this with others.

andrewjpage added a commit that referenced this pull request Apr 1, 2015
@andrewjpage andrewjpage merged commit 969366e into sanger-pathogens:master Apr 1, 2015
@bewt85 bewt85 deleted the BT5_fix_tests branch April 1, 2015 23:06
@bewt85 bewt85 restored the BT5_fix_tests branch April 6, 2015 13:15
@bewt85 bewt85 deleted the BT5_fix_tests branch April 15, 2015 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants