Ticket 453529 Fix MLST spreadsheet output #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Right PR, wrong description. One moment please. |
bewt85
changed the title
|
Apologies, fixed now. |
…abase getstore doesn't die if the data is missing so I've added a check. I've also added some tests but they throw warnings about dodgy Prototypes. I think this is because I don't understand mocking properly but I've already spent far too long on this and it's just us who run the tests anyway, probably
This will cope better when we quote strings in the output
|
rebased on #50; tests still pass :) |
andrewjpage
added a commit
that referenced
this pull request
Apr 14, 2015
Ticket 453529 Fix MLST spreadsheet output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Excel seems to get confused by CSVs if there are two tabs in a row and (by default) merges them. This messes up the alignment. I've therefore updated the code to quote all the things but unfortunately it turns out that we were re-reading some of what we write using a split which meant that we triple quoted some things.
I've fixed it now though.
Includes changes from #50 so best to merge that one first.