Order alleles consistently when concatonating #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alleles should be sorted by name and not by their sequence when concatenating mlst genes
Actual and expected files were in the wrong order
Also update test data
andrewjpage
added a commit
that referenced
this pull request
Feb 2, 2016
Order alleles consistently when concatonating
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when users concatenated allele sequences, they were sorted alphabetically by genomic sequence. In a small number of cases, these meant that the genes came out in a different order which made comparing the output from different samples annoying. Following this change, the sequences are sorted by the name of their allele.
I had a quick look for something to turn a fasta into a phylip and hacked a one off python script. Any suggestions of a good tool for next time would be great.