Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spoof REF_PATH to disallow remote lookup for cram #112

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

tkchafin
Copy link
Contributor

@tkchafin tkchafin commented Sep 9, 2024

Attempts to pre-empt problems in CRAM processing, using the solution discussed in #111

Closes #111

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@tkchafin tkchafin linked an issue Sep 9, 2024 that may be closed by this pull request
@tkchafin tkchafin requested a review from reichan1998 September 9, 2024 15:06
@reichan1998
Copy link
Contributor

Thanks Tyler! It can prevent the remote look up behaviour. Approve now!

@tkchafin tkchafin merged commit 6c6505d into sanger-tol:dev Sep 10, 2024
8 checks passed
@tkchafin tkchafin deleted the spoof_ref_path branch September 10, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Make sure we are handling CRAM files correctly
2 participants