Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DPL-865 handle sprint client response #2130

Merged
merged 32 commits into from
Jan 29, 2025
Merged

DPL-865 handle sprint client response #2130

merged 32 commits into from
Jan 29, 2025

Conversation

dasunpubudumal
Copy link
Contributor

@dasunpubudumal dasunpubudumal commented Dec 17, 2024 •
edited
Loading

Closes #1352

Changes proposed in this pull request

  • Handling SPrint response

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

yoldas and others added 5 commits December 3, 2024 15:17
@dasunpubudumal dasunpubudumal self-assigned this Dec 17, 2024
@dasunpubudumal dasunpubudumal linked an issue Dec 17, 2024 that may be closed by this pull request
DPL-865 [Limber] Handle sprint client response #1352
Closed
3 tasks
@dasunpubudumal dasunpubudumal marked this pull request as draft December 17, 2024 09:08
@codecov Codecov
Copy link

codecov bot commented Dec 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.81%. Comparing base (568f076) to head (a838885).
Report is 33 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2130      +/-   ##
===========================================
+ Coverage    80.79%   80.81%   +0.02%     
===========================================
  Files          476      476              
  Lines        18191    18212      +21     
  Branches       269      269              
===========================================
+ Hits         14697    14718      +21     
  Misses        3492     3492              
  Partials         2        2
Flag Coverage Δ
javascript 74.23% <ø> (ø)
pull_request 80.81% <100.00%> (+0.02%) ⬆️
push 80.81% <100.00%> (+0.02%) ⬆️
ruby 91.30% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dasunpubudumal dasunpubudumal marked this pull request as ready for review December 17, 2024 10:54
BenTopping
BenTopping requested changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@BenTopping BenTopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, couple advisories. I haven't tested locally.

spec/models/print_job_spec.rb Outdated Show resolved Hide resolved
spec/models/print_job_spec.rb Outdated Show resolved Hide resolved
spec/models/print_job_spec.rb Outdated Show resolved Hide resolved
app/models/print_job.rb Outdated Show resolved Hide resolved
spec/models/print_job_spec.rb Outdated Show resolved Hide resolved
andrewsparkes
andrewsparkes requested changes Jan 7, 2025
View reviewed changes
Copy link
Member

@andrewsparkes andrewsparkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like Bens suggested changes.
My minor one was the error message if sprint is down, can we do something to intercept and change that into something more friendly (might need a separate story).

app/models/print_job.rb Outdated Show resolved Hide resolved
spec/models/print_job_spec.rb Outdated Show resolved Hide resolved
spec/models/print_job_spec.rb Outdated Show resolved Hide resolved
andrewsparkes
andrewsparkes approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@andrewsparkes andrewsparkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements, thanks.

Not sure the user will like the 'try again later' messages, but this is much better than getting no label and nothing at all from LIMS to indicate why. And they can raise a clearer support message if needed.

BenTopping
BenTopping reviewed Jan 21, 2025
View reviewed changes
Copy link
Contributor

@BenTopping BenTopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, codecov complaining about tests I have mentioned.

spec/models/print_job_spec.rb Show resolved Hide resolved
@dasunpubudumal dasunpubudumal merged commit 763bf39 into develop Jan 29, 2025
14 checks passed
@dasunpubudumal dasunpubudumal deleted the 1352-dpl-865-limber-handle-sprint-client-response branch January 29, 2025 10:18
@github-actions github-actions bot mentioned this pull request Jan 29, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsparkes andrewsparkes andrewsparkes approved these changes

@BenTopping BenTopping BenTopping approved these changes

@yoldas yoldas Awaiting requested review from yoldas

Assignees

@dasunpubudumal dasunpubudumal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DPL-865 [Limber] Handle sprint client response
5 participants
@dasunpubudumal @andrewsparkes @BenTopping @yoldas @sdjmchattie