Self registration as end user #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seenanair
reviewed
Feb 12, 2024
| }); | ||
| }); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
It would be better to add a similar test case for 'Sign In' option as well.
There was a problem hiding this comment.
Also, just a doubt , may be a core side question, @khelwood - what will happen if an existing user clicks register button? Would it re-register an existing user or give a warning that user exists already?
There was a problem hiding this comment.
@seenanair,in case a user registers with existing credentials, the core handles it as a standard login process
| <LoginButton loading={formik.isSubmitting} data-testid="signIn" disabled={formik.isSubmitting}> | ||
| Sign In | ||
| </LoginButton> | ||
| </div> |
There was a problem hiding this comment.
Just a UI thought, Would it be better to add an 'Or' in between Register and Sign In and to mention in smaller font/Italics for 'Existing users' near to Sign In ?
…ration # Conflicts: # src/types/sdk.ts
seenanair
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.