DPL-754 Add new field priority_level to sample table #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sangeetha-Bheeman
changed the title
2 tasks
stevieing
requested changes
Jul 25, 2023
There was a problem hiding this comment.
Could you update the tests please? to ensure the fields are included in the json. https://github.com/sanger/unified_warehouse/blob/develop/spec/models/pac_bio_run_spec.rb
| class AddFieldsToLongReadQcResults < ActiveRecord::Migration[7.0] | ||
| def change | ||
| change_table :long_read_qc_result, bulk: true do |t| | ||
| t.string :priority_level, comment: 'Priority level eg Medium, High etc' |
There was a problem hiding this comment.
Again @emrojo I think we need to check that these are relevant.
There was a problem hiding this comment.
Update from meeting 27/07: date_required_by and reason_for_priority are no longer required and can be removed from this schema. priority_level is not a qc_result attribute but should be moved to sample.
There was a problem hiding this comment.
Done. Added the migration to add priority_level to sample table.
…ration for long_read_qc_results
Sangeetha-Bheeman
changed the title
harrietc52
reviewed
Aug 4, 2023
emrojo
reviewed
Sep 4, 2023
| @@ -5,6 +5,7 @@ on: | |||
| branches: | |||
| - master | |||
| - develop | |||
| - dpl-754-add-fields-to-long-read-qc-results | |||
emrojo
reviewed
Sep 4, 2023
Co-authored-by: Harriet Craven <harrietc52@users.noreply.github.com>
emrojo
approved these changes
Sep 4, 2023
Sangeetha-Bheeman
deleted the
dpl-754-add-fields-to-long-read-qc-results
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Changes proposed in this pull request: